Jump to content
Wolfram

Plastic 7.x incredibly slow?

Recommended Posts

Hiho.

We recently upgraded from 6.*.1765 to 7.*.2082. And we immediately noticed several performance problems of the Plastic client. For example:

- When clicking on individual changesets in the branch explorer, the info in the "Properties" panel updated instantaneously in 6.x. Now however, you need to wait 0.5-1 seconds after each click for that information to update. This is not a critical problem, but it still is kinda annoying.

- When refreshing the pending changes view, the rotating icon with "Finding changes in workspace..." takes now SEVERAL seconds each time with a moderate amount of "Private" files (say 100-300, which is not much in a Unity project during normal workflow), although this process was barely noticeable in 6.x. This problem feels extremely annoying, especially since we discovered the "Auto-refresh pending changes" option a while ago, and it was just PERFECT, as before people often forgot to refresh the client and therefore often commitet only half of the stuff they wanted to.

I attached our current Pending Changes options. YES I do realize the smallprint what with "lots of private files, this operation could take a while". But as I said, we never noticed any annoying delays in 6.x,  but with 7.x and the "auto-refresh" enabled, the Pending Changes takes several seconds each time the window is re-focused, so even just switching between two windows will trigger the delay. Also, we did not modify any pending changes options between the client upgrade, meaning, we always had "show changed" and "show private" enabled, as well as the two "show manually...".

Is there a way to get to the old, fast behaviour (without having to disable the auto-refresh (which would be a pity) or the "show private" option (which is mandatory for us, to prevent inconsistencies), or is this indeed a regression and will be fixed in the next update?

A positive change seems to be that for projects connected to Jira, refreshing the branch explorer will now instantly(?) show detailed branch titles/infos in the main view, while this procedure took around 8-10 seconds with 6.x. Are these infos now cached?

Our server configuration: external host via ssl, usual ping rates 5-6ms.

Local workspaces located on an internal SSD.

Plastic_bugreport.png

Share this post


Link to post
Share on other sites

Hi Wolfram,

We're shocked by this slower pending changes, and we have been checking since we received this 3 hours ago.

@ruben, @Borja and I are looking into this.

Regarding the slower update in Branch Explorer: this can happen because we moved out requests from the main thread, to avoid the GUI hanging. I'll check with Violeta if we can reduce the wait time.

Share this post


Link to post
Share on other sites

Yes, we moved out requests from the main thread in 7.0.16.1944. But, the server call done to update the "Properties" panel when a changeset is selected in the branch explorer didn't change. Maybe we could see anything else in the logs. Anyway, I will check it in more detail in case it's affected by other change...

 

 

 

Share this post


Link to post
Share on other sites

Hi again,

We see the Branch Explorer is slower, and @vsanchezm confirms is not a threading issue. She's going to look deeper into it.

 

Now, we are NOT able to reproduce the most important problem: slower pending changes. We are unable to reproduce it (which matches with our belief, because we didn't make changes on that area, although we might be mistaken). Perf is high prio for us, so any other feedback is welcome.

 

Thanks,

 

pablo

Share this post


Link to post
Share on other sites

I found the issue that slows down the properties update :(

It will be fixed in the next release.

Thanks and sorry for the inconveniences.

Violeta

  • Thanks 1

Share this post


Link to post
Share on other sites
1 hour ago, psantosl said:

Now, we are NOT able to reproduce the most important problem: slower pending changes. We are unable to reproduce it (which matches with our belief, because we didn't make changes on that area, although we might be mistaken). Perf is high prio for us, so any other feedback is welcome.

Hi Pablo!

Thanks for the quick response!

I re-checked with two of our projects, and re-installed 6.0.16.1765, and then 7.0.16.2082 again (we didn't test/use any versions in-between), and there is a clear (and big) performance drop with the newer version. I created a screencapture for each case: https://drive.google.com/open?id=1G9CQZrPvco7-KO1ZgPTbE02cQNqHa2DQ

I changed nothing between re-installs, and no Unity or VS (or other CPU hogs) were running during the recordings.

Hope this helps, please tell me if I can be of further assistance in tracking down this problem!

Cheeers,

Wolfram

Share this post


Link to post
Share on other sites

Some more infos:

- I do remember having seen something about pending changes performance in the changelogs, maybe it's related: 7.0.16.1930 "The pending changes view performance was severely degraded when there were tons of changed items in view. This was broken when the tree mode ("view items as a tree"). It was only appreciable with tons of pending changes. Now it's fixed."

- there is no difference whether I switch to tree view or use list view

- toggling "Show changes grouped by changelists" also has no effect

 

Share this post


Link to post
Share on other sites

Hi, We would like to get connected to debug your scenario. I've sent you an email.

Regards,

Carlos.

Share this post


Link to post
Share on other sites

Hi all,

 

Thanks to Wolfram we found an issue in a log setting we changed in 7.0. The client log is set to 

 

lockingModel type="log4net.Appender.FileAppender+MinimalLock

 

Which is making some antivirus to go nuts and incredibly downgrade performance.

 

We are going to change it in the official release.

 

If you find this issue, you can edit your plastic.log.conf, or cm.log.conf and modify it to be like

 

appender name="FileAppender" type="log4net.Appender.FileAppender"

 

Case closed 🙂

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

×